18.0 migration survey legal#226
Conversation
Aside from migration adaptations: - Drop website_require_legal dependency - Validation is now performed in js insead of the view so we need to do so. - Additional control for the legal terms link and text TT44775
Currently translated at 22.2% (2 of 9 strings) Translation: survey-15.0/survey-15.0-survey_legal Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_legal/it/
Currently translated at 100.0% (9 of 9 strings) Translation: survey-15.0/survey-15.0-survey_legal Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_legal/es/
layadelcarmen
force-pushed
the
18.0-migration-survey_legal
branch
from
a7f4c1f to
ca8bea6
Compare
|
I noticed the CI run is failing with a warning related to Chrome (a "Killing chrome descendants-or-self" message picked up by oca_checklog_odoo). I haven't been able to reproduce this locally and it doesn't seem related to the module code itself, but I wanted to flag it in case it's a known issue or if there's something specific I should do on my end to address it. Thank you in advance. @benbrich Check this out when you have a chance |
benbrich
left a comment
benbrich
left a comment
There was a problem hiding this comment.
Functional test on runboat, all fine. Legal terms are displayed, link is correct and survey can only be finished when bool is true.
chandni299
left a comment
chandni299
left a comment
There was a problem hiding this comment.
LGTM
But we get an error when we try to enable "Activate Test Mode". See screenshots
layadelcarmen
force-pushed
the
18.0-migration-survey_legal
branch
from
ca8bea6 to
0aa2cfc
Compare
|
Thank u for the review. I pushed a fix. |
8 participants
No description provided.