18.0 mig survey question type binary#232
Open
layadelcarmen wants to merge 14 commits into
Open
Conversation
Issue: no answer was created if question not filled. If filled is was marked as Skipped - Create a Skipped answer when the binary question is not filled - If filled, put the file name is the Answer or the number of files in case of binary_multi
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-16.0/survey-16.0-survey_question_type_binary Translate-URL: https://translation.odoo-community.org/projects/survey-16-0/survey-16-0-survey_question_type_binary/
Currently translated at 100.0% (38 of 38 strings) Translation: survey-16.0/survey-16.0-survey_question_type_binary Translate-URL: https://translation.odoo-community.org/projects/survey-16-0/survey-16-0-survey_question_type_binary/it/
Backport of OCA#216 (19.0 migration) adapted for 18.0: - JS rewritten for publicWidget (Odoo 18 still uses legacy widget system) - self.env._() translation API, Command.create(), _validate_binary convention - Replace deprecated get_module_resource with file_path in tests
OCA-git-bot
added
series:18.0
mod:survey_question_type_binary
- Add tests 05-11 covering validate_question super() path, _save_lines non-binary and empty-answer paths, _check_answer_type_skipped, _check_binary_answer filesize/mimetype errors, and _compute_display_name - Simplify _check_answer_type_skipped: remove dead `if field_name and` guard (field_name is always "answer_binary_ids") - Simplify _get_line_answer_values: remove dead isinstance check since answer is always a single dict when called from _save_line_simple_answer
Author
|
@benbrich could you please review this PR? |
sergiocorato
suggested changes
Jun 26, 2026
sergiocorato
left a comment
sergiocorato
left a comment
There was a problem hiding this comment.
Commits do not respect the migration guidelines: there must be a commit for pre-commit ([IMP] survey_question_type_binary: pre-commit auto fixes) and a commit for the migration ([MIG] survey_question_type_binary: Migration to 18.0) (created automatically by oca-port if you use it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.