Datetime support#2984
Open
alex-odysseus wants to merge 26 commits into
Open
Conversation
…er filter expression
…as' into issues-2886 # Conflicts: # js/components/cohortbuilder/CohortExpression.js # js/components/cohortbuilder/EndStrategies/CustomEraStrategy.js # js/components/cohortbuilder/EndStrategies/DateOffsetStrategy.js # js/components/cohortbuilder/InputTypes/Window.js # js/components/cohortbuilder/components/CustomEraStrategyTemplate.html # js/components/cohortbuilder/components/WindowInputTemplate.html # js/components/cohortbuilder/options.js
… Era in criteria group
… Era in criteria group
# Conflicts: # js/components/cohortbuilder/components/WindowInputTemplate.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #2886
When a Cohort is designed it should be possible to choose an explicit checkbox (on top of the form) which urges to use "datetime" columns in runtime for all Criteria if applicable, otherwise by default only Criteria which were explicitly changed to use hours/minutes/seconds will follow that logic, the "old" Cohorts with "days" designs should remain untouched