Skip to content

next/1263/20260310/v1#463

Closed
victorjulien wants to merge 1 commit intoOISF:0.5.xfrom
victorjulien:next/1263/20260310/v1
Closed

next/1263/20260310/v1#463
victorjulien wants to merge 1 commit intoOISF:0.5.xfrom
victorjulien:next/1263/20260310/v1

Conversation

@victorjulien
Copy link
Member

…tput buffer (*plainchar) to store the partial result of the next byte before verifying if the output buffer had sufficient space. This resulted in a heap-buffer-overflow when the provided output buffer was undersized or exactly full.

This patch fixes the issue by:

Moving the partial byte assignment after the buffer length check.
Correctly updating the decoder state (decoder->step and decoder->plainchar) when the buffer limit is reached, ensuring the state is preserved without writing out-of-bounds.
Fixes OISF#458

This patch is generated by ASKRepair, an agentic automated vulnerability repair framework
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 650 626 96.31%
.app_layer.error.ftp-data.gap 2 0 -

Pipeline = 30124

@victorjulien
Copy link
Member Author

Commit message needs cleanup; Juliana has other feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants