升級至 Java 25 + 更新 GitHub Actions SHA pin#332
Conversation
- Velocity 3.4.0-SNAPSHOT → 3.5.0-SNAPSHOT (build 593) - Java 21 → 25 (JVM target and Dockerfile) - Gradle 9.2.1 → 9.3.0 - shadow plugin 9.3.0 → 9.3.1 - kubernetes-client 7.4.0 → 7.5.2 - lettuce-core 6.8.2.RELEASE → 7.2.1.RELEASE
…ore:7.5.1.RELEASE, shadow to 9.4.1
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 16 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's environment and dependencies, including upgrading to Java 25, Kotlin 2.3.20, and Gradle 9.4.1. Key dependency updates include Velocity 3.5.0, Kubernetes Client 7.6.1, and Lettuce 7.5.1. Feedback suggests excluding the Kubernetes HTTP client from the shadow JAR minimization to prevent runtime errors caused by dynamic loading and removing the deprecated '.RELEASE' suffix from the Lettuce dependency version to align with current naming conventions.
| kapt("com.velocitypowered:velocity-api:3.5.0-SNAPSHOT") | ||
| compileOnly("com.velocitypowered:velocity-api:3.5.0-SNAPSHOT") | ||
| implementation("io.fabric8:kubernetes-client:7.6.1") | ||
| implementation("io.fabric8:kubernetes-httpclient-okhttp:7.6.1") |
There was a problem hiding this comment.
由於專案在 shadowJar 任務中啟用了 minimize() 功能（見第 48 行），建議將 io.fabric8:kubernetes-httpclient-okhttp 也加入排除名單。Fabric8 的 HTTP 客戶端實作通常是透過 ServiceLoader 機制動態載入的，若未顯式排除，最小化過程會因偵測不到直接引用而將其移除，導致程式執行時出現 No HTTP client implementation found 錯誤。
| implementation("io.fabric8:kubernetes-httpclient-okhttp:7.6.1") | ||
| implementation("com.github.fkorotkov:k8s-kotlin-dsl:3.5.0") | ||
| implementation("io.lettuce:lettuce-core:6.8.2.RELEASE") | ||
| implementation("io.lettuce:lettuce-core:7.5.1.RELEASE") |
There was a problem hiding this comment.
Lettuce 官方自 6.0 版本起已停止在版本號中使用 .RELEASE 後綴。建議移除此後綴以符合目前的版本命名規範，並避免未來潛在的依賴解析問題。
implementation("io.lettuce:lettuce-core:7.5.1")There was a problem hiding this comment.
@gemini-code-assist 有來源嗎，我目前在最新版本中仍看到 .RELEASE 字樣
There was a problem hiding this comment.
您說得對，Lettuce 確實仍在發布帶有 .RELEASE 後綴的版本（例如您提到的 7.5.1.RELEASE）。
我之前的建議是基於 Lettuce 專案在 GitHub Release 頁面 上逐漸減少使用該後綴的趨勢，以及許多現代 Java 專案傾向於簡化版本號的慣例。不過，既然官方 Maven 倉庫中確實存在 7.5.1.RELEASE，保留該後綴是完全正確且安全的做法，不會影響依賴解析。感謝您的指正。
1 participant
摘要
更新 Galaxy-proxy 以相容 26.1.2：
建置變更
依賴更新
GitHub Actions CI（已更新為 SHA pin）
破壞性變更