Adjustments in response to reviewer feedback#48
Merged
lunamorrow merged 3 commits intomainfrom Jan 28, 2025
Merged
Conversation
…-examples' and have updated module import paths in the PolyTop examples both in 'paper_worked_examples.ipynb' and on the documentation
Contributor
Author
|
Most recent commit to remove the PolyConf/PolyTop automated polymer builder per request from @recombinatrix. The automated builder has been removed from the module code base and all documentation. |
9 tasks
…ructions more explicit for the purpose of debugging a common build error
Contributor
Author
|
Merging this into main for now. May need to make documentation more explicit, make a few changes to example ipynb and add CG example in later PR. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist of changes for review:
Other discussed changes:
Maybe: