Draft
Conversation
Arnovsky
reviewed
Jul 11, 2022
gioragutt
reviewed
Jul 11, 2022
| return function (_target: Object, propertyKey: string, descriptor: PropertyDescriptor) { | ||
| const originalMethod = descriptor.value; | ||
| const metricName = `${prefix}${prefix ? '.' : ''}${propertyKey}`; | ||
| descriptor.value = monitored(metricName, originalMethod, options); |
Contributor
There was a problem hiding this comment.
Suggested change
| descriptor.value = monitored(metricName, originalMethod, options); | |
| descriptor.value = (...args) => monitored(metricName, () => originalMethod(...args), options); |
monitored calls the method, you need descriptor.value to be a method
| "experimentalDecorators": true | ||
| }, | ||
| "include": ["src/**/*", "types/*.d.ts"], | ||
| "include": ["src/**/*", "types/*.d.ts", "example/**/*"], |
Contributor
There was a problem hiding this comment.
ensure that it does not cause examples to be part of the dist
| export const gauge: Monitor['gauge'] = (...args) => getGlobalInstance().gauge(...args); | ||
| export const timing: Monitor['timing'] = (...args) => getGlobalInstance().timing(...args); | ||
|
|
||
| export const monitorMethod = <T>(prefix?: string, options: MonitoredOptions<T> = {}) => { |
Contributor
There was a problem hiding this comment.
I'd replace monitorMethod with a function (instead of const) and provide an overload which does not take the prefix parameter.
I want to avoid @monitorMethod(undefined, {...}).
Or, just make prefix required. What use cases do we have that we don't add some prefix to your monitor call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issues does it affect?
What it does