Filter f extremes and deduplicate generic signals#139
Open
oliverchampion wants to merge 1 commit intomainfrom
Open
Filter f extremes and deduplicate generic signals#139oliverchampion wants to merge 1 commit intomainfrom
oliverchampion wants to merge 1 commit intomainfrom
Conversation
Update signal generation to ignore voxels with extreme perfusion fractions and avoid duplicate parameter combos. sim_ivim_sig.py: expand the ignore mask to include f<0.03 or f>0.97 in addition to NaNs, compute median D/f/Dp per selector and skip adding entries if the (D,f,Dp) combination was already seen. Update unit test fixtures tests/IVIMmodels/unit_tests/generic.json and generic_DL.json to reflect the removed/changed entries expected from the new filtering/deduplication behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update signal generation to ignore voxels with extreme perfusion fractions and avoid duplicate parameter combos. sim_ivim_sig.py: expand the ignore mask to include f<0.03 or f>0.97 in addition to NaNs, compute median D/f/Dp per selector and skip adding entries if the (D,f,Dp) combination was already seen. Update unit test fixtures tests/IVIMmodels/unit_tests/generic.json and generic_DL.json to reflect the removed/changed entries expected from the new filtering/deduplication behavior.
Describe the changes you have made in this PR
A clear and concise description of what you want to happen
Link this PR to an issue [optional]
Fixes #ISSUE-NUMBER
Checklist