Skip to content

[patch]: fix web sideload with manifest preview #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[patch]: fix web sideload with manifest preview #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/office-addin-dev-settings/src/sideload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,9 @@ export async function generateSideloadUrl(
if (!manifest.id) {
throw new ExpectedError("The manifest does not contain the id for the add-in.");
}

if (
manifest.defaultSettings === undefined ||
manifest.defaultSettings.sourceLocation === undefined
) {
throw new ExpectedError("The manifest does not contain the SourceLocation for the add-in");
}

manifest.defaultSettings = manifest.defaultSettings ?? {};
manifest.defaultSettings.sourceLocation = manifest.defaultSettings.sourceLocation ?? "https://localhost:4000";
Copy link
Collaborator

@millerds millerds Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right default. It assumes that people are deploying their test add-in code to localhost:4000 which isn't even the location used in the add-in projects we generate from templates using 'yo office' (which is port 3000) and in those it is written that way into the manifest.


const sourceLocationUrl: URL = new URL(manifest.defaultSettings.sourceLocation);
if (sourceLocationUrl.protocol.indexOf("https") === -1) {
Expand Down