feat(config): make trips-for-route running windows configurable#810
Open
cotishq wants to merge 1 commit into
Open
feat(config): make trips-for-route running windows configurable#810cotishq wants to merge 1 commit into
cotishq wants to merge 1 commit into
Conversation
b74d528 to
8c3c4ff
Compare
Contributor
Author
|
@Ahmedhossamdev hey can you review this and let me know what changes it still requires before getting merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #800 by making trips-for-route activity windows configurable instead of hardcoded.
Previously,
trips-for-routeused fixed values:30m10mNow both are configurable via
config.jsonwhile preserving the same defaults.What changed
running-late-window(seconds, default1800)running-early-window(seconds, default600)time.Duration).trips_for_route_handlerto use configured windows with default fallback behavior.README.markdownconfig.schema.jsonconfig.example.jsonconfig.docker.example.jsonBackward compatibility
30m10mIssue
Closes #800