-
Notifications
You must be signed in to change notification settings - Fork 77
PR to put all root stuff into one script #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
19a9aa9 "We have to assume git installed otherwise another script needs root" That will probably break build on archlinux as git is not in base-devel. You may be able to ensure git is present on arch github runners, but not on archlinux user systems. |
AnotherCommander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on Windows with legacy and Clang environments, no issues,
Testing on Linux platforms will be required to confirm the Linux side of things, as I do not have such systems available for testing.
Lone Wolf's comment should also be considered, so I'll stand by for a bit before merging to give some time to act on that.
|
@LW-archlinux I have updated the README to make it clear that the first step is to install git. I think it's reasonable for us to expect developers to do that since they need git to obtain the source code in the first place. |
Add function to get AddOns folder in game dir (even when an AppImage)
|
@AnotherCommander I have added gameDirAddOnsPath to OOOXZManager.m to get the AddOns folder relative to AppImage if running an AppImage otherwise get ./Addons for Linux or ../AddOns for Windows as before. |
Agreed. |
As per LW's suggestions, put all root stuff into one script.
Also adds Ubuntu latest test build
Only adds -std=gnu99 for gcc on Linux