Skip to content

Conversation

@mcarans
Copy link
Contributor

@mcarans mcarans commented Dec 20, 2025

As per LW's suggestions, put all root stuff into one script.

Also adds Ubuntu latest test build

Only adds -std=gnu99 for gcc on Linux

@LW-archlinux
Copy link

LW-archlinux commented Dec 20, 2025

19a9aa9 "We have to assume git installed otherwise another script needs root"

That will probably break build on archlinux as git is not in base-devel. You may be able to ensure git is present on arch github runners, but not on archlinux user systems.

Copy link
Member

@AnotherCommander AnotherCommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on Windows with legacy and Clang environments, no issues,

Testing on Linux platforms will be required to confirm the Linux side of things, as I do not have such systems available for testing.

Lone Wolf's comment should also be considered, so I'll stand by for a bit before merging to give some time to act on that.

@mcarans
Copy link
Contributor Author

mcarans commented Dec 20, 2025

@LW-archlinux I have updated the README to make it clear that the first step is to install git. I think it's reasonable for us to expect developers to do that since they need git to obtain the source code in the first place.

Add function to get AddOns folder in game dir (even when an AppImage)
@mcarans
Copy link
Contributor Author

mcarans commented Dec 20, 2025

@AnotherCommander I have added gameDirAddOnsPath to OOOXZManager.m to get the AddOns folder relative to AppImage if running an AppImage otherwise get ./Addons for Linux or ../AddOns for Windows as before.

@LW-archlinux
Copy link

@LW-archlinux I have updated the README to make it clear that the first step is to install git. I think it's reasonable for us to expect developers to do that since they need git to obtain the source code in the first place.

Agreed.

@AnotherCommander AnotherCommander merged commit f5066bd into OoliteProject:master Dec 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants