Conversation
Bumps [org.jetbrains.kotlin:kotlin-stdlib](https://github.com/JetBrains/kotlin) from 2.3.0 to 2.3.10. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.3.0...v2.3.10) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-version: 2.3.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.14.1 to 3.15.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.14.1...maven-compiler-plugin-3.15.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-version: 3.15.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ons for tool execution
…aven.plugins-maven-compiler-plugin-3.15.0 chore(deps-dev): bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.1 to 3.15.0
…s.kotlin-kotlin-stdlib-2.3.10 chore(deps): bump org.jetbrains.kotlin:kotlin-stdlib from 2.3.0 to 2.3.10
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
…pability Add OAF_PIDFILE environment variable override for ow.server.checkIn
…FAndRun, and endOpenAFAndStartOpenAF functions Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
…stopOpenAFAndRun Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
…direction Add optional output redirection control to process spawn functions
…responses and improving payload parsing logic
…ore accessing lineNumber
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances OpenAF with process management capabilities, semantic version sorting, and JSON-RPC/MCP client customization. The changes add support for detached process execution, improve table sorting with semantic versioning, enable per-call HTTP options for remote MCP tools, and introduce OAF_PIDFILE environment variable support for flexible PID file management.
Changes:
- Added detached process management functions (
endOpenAFAndStart,endOpenAFAndStartOpenAF) with platform-specific handling for Unix/Windows - Enhanced
stopOpenAFAndRunwith output redirection and conditional termination options - Implemented semantic version parsing and comparison for table sorting with full SemVer precedence rules
- Extended
$jsonrpc.execand$mcp.callToolwith per-call HTTP options viaaExecOptions/toolOptionsparameters - Added OAF_PIDFILE environment variable support to override PID file paths in
ow.server.checkIn - Improved SSE stream handling in Gemini AI integration to handle non-SSE error responses and single-line JSON events
- Updated dependencies (maven-compiler-plugin, postgresql, kotlin-stdlib, ojdbc17)
Reviewed changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| js/openaf.js | Added detached process functions, enhanced stopOpenAFAndRun with redirection/noStop, updated restartOpenAF logic, added timer docs, improved $jsonrpc/$mcp with per-call options, enhanced error handling null check, exposed AF.endOpenAFAndStart |
| js/owrap.server.js | Added OAF_PIDFILE environment variable override in checkIn, fixed JSON-RPC notification null output |
| js/owrap.ai.js | Enhanced SSE stream reader to handle Gemini single-line JSON events and non-SSE error responses |
| js/mdtablesort.js | Added parseSemVer and compareSemVer functions with full SemVer precedence support, integrated into table sort |
| tests/autoTestAll.Server.js | Added comprehensive tests for checkIn PID file behavior including OAF_PIDFILE override scenarios |
| tests/autoTestAll.Server.yaml | Added Server::CheckIn test job |
| pom.xml | Updated maven-compiler-plugin (3.15.0), postgresql (42.7.10), kotlin-stdlib (2.3.10), ojdbc17 (23.26.1.0.0) |
| docs/openaf.md | Documented OAF_PIDFILE environment variable for PID file override |
| docs/openaf-flags.md | Added Server Management section documenting OAF_PIDFILE |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to process management, semantic version handling, and JSON-RPC/MCP client customization in OpenAF. The changes improve the ability to manage OpenAF processes (including restarting and detaching), add robust semantic version sorting for tables, and allow per-call HTTP options for remote MCP tool invocations. Documentation and API usability have also been updated.
Process Management Enhancements:
restartflag to__flagsand extendedstopOpenAFAndRunto support output redirection and conditional process termination. IntroducedendOpenAFAndStartandendOpenAFAndStartOpenAFfunctions for detached process handling, with argument quoting for both Unix and Windows. Exposed these asAF.prototype.endOpenAFAndStartfor easier use. [1] [2] [3] [4]restartOpenAFto usestopOpenAFAndRunfor consistent restart logic and proper argument handling. [1] [2] [3]OAF_PIDFILEenvironment variable. [1] [2]Semantic Version Sorting:
parseSemVerandcompareSemVerfunctions tojs/mdtablesort.jsfor parsing and comparing semantic versions, and integrated them into table sorting logic to prioritize semantic version sorting before date/string checks. [1] [2]JSON-RPC and MCP Client Customization:
$jsonrpc.execand$mcp.callToolto accept per-call HTTP options via a newaExecOptions/toolOptionsargument, enabling custom headers and settings for remote MCP calls. Updated documentation and examples to reflect these changes. [1] [2] [3] [4] [5] [6] [7] [8]Timer Utilities:
setTimeout,setInterval, andclearIntervalfunctions for scheduling code execution, including non-blocking intervals using threads. [1] [2]API and Documentation Improvements:
Let me know if you want to see usage examples or details on any specific feature!