fix(cli): repair load_wallets_on_start import after indexer rename#240
Open
rdmcd wants to merge 1 commit intoOpenBuilders:mainfrom
Open
fix(cli): repair load_wallets_on_start import after indexer rename#240rdmcd wants to merge 1 commit intoOpenBuilders:mainfrom
rdmcd wants to merge 1 commit intoOpenBuilders:mainfrom
Conversation
The CLI imported `from indexer.tasks ...`, but the package was renamed to `indexer_blockchain` and the CLI was missed. Running `python -m core.cli.load_wallets_on_start` raised ModuleNotFoundError before any side effect, so the recovery path for the external wallet-tracking Redis was unavailable.
Contributor
There was a problem hiding this comment.
Pull request overview
Repairs the core CLI module load_wallets_on_start by updating an outdated import to the post-split indexer package layout, restoring the ability to enqueue wallet-detail fetch tasks and re-seed the external wallet-tracking Redis after data loss.
Changes:
- Update
fetch_wallet_detailsimport from the removedindexer.tasksmodule toindexer_blockchain.tasks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
I recommend decommissioning this CLI, since there is no one with cluster access, and it is only for local development. Unless you see a use for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/cli/load_wallets_on_start.pyimportsindexer.tasks, which no longer exists — the package was split intoindexer_blockchain/indexer_gifts/indexer_price/indexer_stickersand this CLI was missed.python -m core.cli.load_wallets_on_startraisesModuleNotFoundError: No module named 'indexer'on import, before any DB read or Redis write happens.REDIS_TRANSACTION_DB). After any loss of that DB (volume reset,FLUSHDB, OOM beforeBGSAVE, etc.) tracked wallets cannot be re-seeded from the database, andtransaction-lookupstops emittingnoticed_walletsevents for the affected addresses — leading to stale on-chain ownership in the local DB and members not being kicked when they no longer meet eligibility rules.Fix
One-line rename of the import:
Test plan
Dockerfile.indexer-blockchainagainst this branch.python -c "from core.cli.load_wallets_on_start import load_wallets_on_start"resolves successfully inside the container (was failing withModuleNotFoundErroronmain).