Conversation
synackd
approved these changes
May 6, 2025
Collaborator
synackd
left a comment
synackd
left a comment
There was a problem hiding this comment.
Amazing it got this far without being noticed. Thanks for the fix! LGTM.
Contributor
Author
|
I think maybe newer go vet versions have added stricter checks? IDK, I've found a few cases like this where the repo hadn't been touched much recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several JSON tags had quotes in the wrong place, which makes vet mad. This changes them to the correct form.