Make metadata expiration time configurable#1860
Open
AramMutluWork wants to merge 1 commit intoOpenConext:mainfrom
Open
Make metadata expiration time configurable#1860AramMutluWork wants to merge 1 commit intoOpenConext:mainfrom
AramMutluWork wants to merge 1 commit intoOpenConext:mainfrom
Conversation
MKodde
reviewed
Nov 3, 2025
Member
MKodde
left a comment
There was a problem hiding this comment.
A nice and useful new contribution!
I see a lot of nice things, but looking at this critically, I have some suggestion/questions:
- Now that the exp time is no longer hard coded; would we not need some validation/verification if a correct value is configured? What happens with negative values, floating points, string values,... This validation does not need to be very comprehensive, and by looking at your type definition, the application only allows for integer values. But that can still be a negative value. Maybe check for that in the MetadataRenderer constructor?
- I'd love to see the MetaDataRendererTest be extended with a couple of additional tests to verify that the expected expiration time matches with the one configured
Comment on lines
+348
to
+349
| $addRequestedAttributes, | ||
| 86400 |
Member
There was a problem hiding this comment.
Aside from fixing the test by passing the new parameter, it might be very useful to add a couple of tests that verify the expiration time ends up correctly in the metadata?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expiration time of the metadata defines the validUntil until attribute in the metadata of Engineblock. By default this a constant in the code set to 86.400 seconds (24 hours).
At the request of one of the connected Service Providers, we want to increase this value to 1,814,400 seconds (21 days). If something goes wrong with the automatic reading of our metadata, they will have more time to fix this error before users experience login problems.
To avoid having to set this up again with every release, we want to make this configurable, I left the default at 24 hours as before.