Update bakker.R#33
Closed
sklesse wants to merge 1 commit into
Closed
Conversation
detected a bug, where BAI was not properly calculated and stored in the "out" object. fixed now
Collaborator
|
Good catch - the bug is confirmed. Master has moved on enough since this PR was opened that there's a merge conflict, so I applied the fix by hand rather than deal with the conflict resolution. Thanks for tracking this down and for the clear explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detected a bug, where the BAI was miscalculated in the first row of the data.frame because of the diff() function and the unreplaced DBHhist in the BAI object "out".
That should be fixed now.