vs-build: change OpenFAST-Simulink target name#3299
Open
andrew-platt wants to merge 1 commit intoOpenFAST:rc-5.0.1from
Open
vs-build: change OpenFAST-Simulink target name#3299andrew-platt wants to merge 1 commit intoOpenFAST:rc-5.0.1from
andrew-platt wants to merge 1 commit intoOpenFAST:rc-5.0.1from
Conversation
…lab_Release.dll to OpenFAST-Simulink.dll During the `deploy` step on GH, the `mex` call uses the `OpenFAST-Simulink_Matlab_Release.lib` file to set the name of the linked DLL. However, we rename the dll itself to not include `_Matlab_Release` in the name, but the .lib file still contains this. This causes a descrepancy between the linked name in the mexw64 and the provided dll. Rather than hack the .lib file to change the name in there, we'll simply modify the vfproj file to produce the OpenFAST-Simulink.dll and corresponding .lib file with the correct name information in it. This fixes issue OpenFAST#3274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge.
Feature or improvement description
Changed build target release name from
OpenFAST-Simulink_Matlab_Release.dlltoOpenFAST-Simulink.dllDuring the
deploystep on GitHub, themexfunction build call uses theOpenFAST-Simulink_Matlab_Release.libfile to set the name of the linked DLL. However, we rename the DLL itself to not include_Matlab_Releasein the name, but the .lib file still contains this. This causes a discrepancy between the linked name in the mexw64 and the provided DLL.Rather than hack the .lib file to change the name in there, we'll simply modify the vfproj file to produce the
OpenFAST-Simulink.dlland corresponding.libfile with the correct name information in it.Related issue, if one exists
This fixes issue #3274
Impacted areas of the software
This really only affects the automated Windows builds for the Matlab Simulink mex function.
Additional supporting information
The alternative approach would be to not rename the resulting
dllfile for Simulink, but this approach is simpler.Generative AI usage
None
Test results, if applicable
No changes