Use cibuildwheel to automatically build all the wheels, avoid manual builds#935
Use cibuildwheel to automatically build all the wheels, avoid manual builds#935BishopWolf wants to merge 8 commits into
Conversation
|
@tbaudier right now we only support these os however, to support more we just need to add them, they will be built by default ALSO: No need to further worry about python version, the variable |
7a11eb7 to
12b7d7e
Compare
|
@tbaudier This is clean and ready, you can merge if approved |
|
Thank you, First we want to do the release and then I will have a look to your PR |
|
@tbaudier windows is fully automatic now. |
421b6ed to
5e3e4ce
Compare
|
Windows and Linux build in less than 10 minutes per python version |
5e3e4ce to
776c6fd
Compare
|
@tbaudier we can leave the one wheel per python version if you think the builds are too slow. EDIT: I can see it's definitely faster, i'll push the changes |
f3cb3d9 to
556613e
Compare
|
@tbaudier I can add back python 3.10 support for both windows and macos, it is building fine for me. |
|
brew qt should be fine for all macos versions accordingly to https://formulae.brew.sh/formula/qt. the cache should handle it |
ec73c44 to
5f62653
Compare
|
I have rebased the last working commit to current master. I can add the intended modifications in a different PR. Current issues: When using homebrew cache in mac : cibuildwheel can't find system python |
|
Hello @BishopWolf can you rebase the PR please, specially with the new version tag, your commit c616243 should be removed. Then I will test the visualization part. Thank you |
cc9abd8 to
231cff3
Compare
|
@tbaudier I have also tested in a macos-15-intel I have, and it builds fine with passing tests on python 3.12 |
|
Thank you, I will do some test because I have a macos intel to check the visualisation. I let you know |
Remove condition to be able to run CI for all OS Allow us to try the vizu with the new ci
|
@tbaudier EDIT: Confirmed for these OS: Miniconda 26.3.2-2 So no python 3.14 |
|
In my macos intell brew can install qt, even in the ci it could. But somehow delocate can't find it. This is weird, i'll revert to conda qt |
|
@tbaudier windows arm is not suppported by conda https://repo.anaconda.com/miniconda/ |
…o install requirements
|
@tbaudier everything is ready to merge. You can do your tests |
|
@tbaudier I really think the issue of brew qt is that geant4 was compiled with conda qt and it doesn't like the brew one. Either we recompile geant4 with brew qt as in macos arm64 or we keep conda for qt in intel which adds extra maintenance burden To keep conda just delete the last two commits |
dab3b2a to
594bad5
Compare
|
@tbaudier since I will change qt installation in another PR, it makes no sense to have it here. I have reverted the last two commits. |
This PR is intended to open a discussion to address the issue #928
This changes current wheel generation. CONFIRM AND APROVE BEFORE MERGE!!!
Current status:
Possible improvements: