Fix incorrect ceiling calculation in ceil_of_element_in_sorted_array.cpp#6839
Open
SinghCod3r wants to merge 1 commit intoOpenGenus:masterfrom
Open
Fix incorrect ceiling calculation in ceil_of_element_in_sorted_array.cpp#6839SinghCod3r wants to merge 1 commit intoOpenGenus:masterfrom
SinghCod3r wants to merge 1 commit intoOpenGenus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description This PR resolves Issue #6832 (“Incorrect Return Value in solve Function”).
Key points • Binary-search condition corrected — now treats arr[mid] > ele as a valid ceiling candidate. • Updates pointer movement accordingly ( high = mid-1 , low = mid+1 ). • Adds guard to return -1 when no ceiling exists. • Keeps expected behavior when ele is present in the array ( ele itself is returned).
Result solve() now reliably returns the smallest element ≥ ele , fixing the previous off-by-one logic and ensuring accurate algorithm-application examples.
closes #6832