Skip to content

Conversation

@wforney
Copy link

@wforney wforney commented Sep 27, 2019

  • Updated all projects to VS 2019, .NET Framework 4.8, and latest Windows 10 target for the C++ project

@nvella
Copy link
Member

nvella commented Sep 27, 2019

Hi @wforney, seems mostly solid. There are a few errors in the CI build as it's still running 2017, appveyor.yml and build.ps1 may need to be updated. https://ci.appveyor.com/project/dotnetfoundation/openlivewriter/builds/27712275#L246

@nvella
Copy link
Member

nvella commented Oct 10, 2019

Hi @wforney, I found some docs which might help out;
https://github.com/microsoft/vssetup.powershell/blob/develop/docs/VSSetup/Select-VSSetupInstance.md#-version

It might be worth changing the version specifier from [15.0,16.0) to [16.0,17.0) - this specifies exactly v16 (Visual Studio 2019). Cheers 👍

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the OpenLiveWriter project from Visual Studio 2017 to Visual Studio 2019, upgrades all .NET Framework projects from version 4.6.1/4.7.2 to 4.8, and updates the C++ project to use the latest Windows 10 SDK (10.0) with the v142 platform toolset.

Changes:

  • Updated C++ project to use Windows SDK 10.0 and Visual Studio 2019 toolset (v142)
  • Upgraded all managed projects to target .NET Framework 4.8
  • Updated build infrastructure (build.ps1, appveyor.yml) to use Visual Studio 2019
  • Updated test dependencies (NUnit 3.4.1→3.12.0, ApprovalTests 3.0.11→4.2.2)

Reviewed changes

Copilot reviewed 45 out of 48 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj Updated C++ project to Windows SDK 10.0 and v142 toolset
src/managed/writer.sln Added build script references to solution items
src/managed/*/*.csproj (multiple) Added TargetFrameworkVersion v4.8 to all managed projects
src/managed/*/app.config (multiple) Updated supportedRuntime to .NET Framework 4.8
src/managed/OpenLiveWriter.Tests/packages.config Updated NUnit and ApprovalTests packages to newer versions
build.ps1 Updated build script for VS 2019 (MSBuild path and error messages)
appveyor.yml Changed build image from VS 2017 to VS 2019
src/managed/LocEdit/Properties/*.Designer.cs Auto-generated code updated to VS 2019 tooling version
Files not reviewed (3)
  • src/managed/LocEdit/Properties/Resources.Designer.cs: Language not supported
  • src/managed/LocEdit/Properties/Settings.Designer.cs: Language not supported
  • src/managed/OpenLiveWriter.Localization/Images.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</assemblyBinding>
</runtime>
</configuration>
<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/></startup></configuration>
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup element should be on a separate line from the closing configuration tag for better readability and consistency with standard XML formatting practices. Having multiple closing tags on the same line makes the configuration file harder to read and maintain.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

</assemblyBinding>
</runtime>
</configuration>
<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/></startup></configuration>
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup element should be on a separate line from the closing configuration tag for better readability and consistency with standard XML formatting practices. Having multiple closing tags on the same line makes the configuration file harder to read and maintain.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

</assemblyBinding>
</runtime>
</configuration>
<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/></startup></configuration>
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup element should be on a separate line from the closing configuration tag for better readability and consistency with standard XML formatting practices. Having multiple closing tags on the same line makes the configuration file harder to read and maintain.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants