Fix flaky transformers_wav2vec2 test#1996
Conversation
6f37ce3 to
6d1c9c8
Compare
|
Do we know why this fixes the issue and why it started at some point? cc: @sssshhhhhh |
|
My guess, its behavior becomes non-deterministic when the thread count isn't explicitly set and different hardware triggered it. |
|
wav2vec with set threads already is still flaky tho. I guess it's some hardware thing |
|
Maybe it could change to jfk, I checked every diff <0.5 can swap and it won't change the output |
…sformers_wav2vec2bert
…est_transformers_wav2vec2bert" This reverts commit f7c71bd.
6d1c9c8 to
50a74ce
Compare
@jordimas |
|
Maybe let's check against both variations, "APOSSTEL" and "APOSSEL"? @3manifold did it passed the check when you reverted |
All tests pass now. Although I can add a commit to check for both "APOSSTEL" and "APOSSEL". Then, it is up to the reviewers to approve the change. |
|
@sssshhhhhh @jordimas I added a check for both "APOSSTEL" and "APOSSEL" in |
Revive
cpu_threadsintest_transformers_wav2vec2similar totest_transformers_wav2vec2bert.resolves #1997