fix issue with return_logits_vocab option#2020
Draft
cmullovisl wants to merge 1 commit intoOpenNMT:masterfrom
Draft
fix issue with return_logits_vocab option#2020cmullovisl wants to merge 1 commit intoOpenNMT:masterfrom
cmullovisl wants to merge 1 commit intoOpenNMT:masterfrom
Conversation
Author
|
Sorry, the current draft only saves the logits of one of the tokens. I will edit it to save all the necessary logits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the
return_logits_vocaboption, the logits of typeStorageVieware saved withemplace_backin theDecodingResult.logits_vocabof typestd::vector<std::vector<StorageView>>. The type mismatch (StorageViewinstead ofstd::vector<StorageView>) results in an emptyStorageViewbeing emplaced intead of the computed logits.