fix: parse embedded ranking JSON#12
Open
alibababye wants to merge 1 commit into
Open
Conversation
Handle nested ranking JSON objects when an LLM wraps the response in explanatory prose. This keeps criterion scores from silently falling back to defaults.
20e19d8 to
95c95d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RankingService._parse_llm_responsecould parse fenced JSON, but the fallback for prose-wrapped responses only matched objects without nested braces. Ranking responses are expected to contain nested criterion objects such asnovelty.score, so a response likeHere is the result: {...}could parse the first inner object instead of the full payload and leave the criteria at default values.Solution
This updates the fallback JSON extraction to capture the full object and adds a regression test for nested ranking JSON embedded in explanatory text.
Testing
Ran in the sandbox: