Skip to content

Further refactoring for mod update#146

Merged
paoloambrosio merged 8 commits into
OpenSimTools:mainfrom
paoloambrosio:27-more-refactoring
Jan 17, 2026
Merged

Further refactoring for mod update#146
paoloambrosio merged 8 commits into
OpenSimTools:mainfrom
paoloambrosio:27-more-refactoring

Conversation

@paoloambrosio
Copy link
Copy Markdown
Contributor

@paoloambrosio paoloambrosio commented Dec 30, 2025

Prerequisite for #27.

Major

  • Track file shadowing installing packages a67927c
  • Decoupled backup strategies from PackagesUpdater by firing events 105a3a4

Bugfixes

  • Any error uninstalling a package will make it partially installed unless all files have been processed bf546d4
  • Tested and fixed (sometimes duplicated) progress notifications d8d62af

Minor

  • Increased test coverage for PackageUpdater 725ed8a
  • Simplified code for processing callbacks c75448e
  • Better handling of null (but not nullable!) fields in saved state 83a7ee0
  • Renamed some method arguments 07a87d7
  • Added some XML Docs 725ed8a

- Made sure that non-nullable fields are assigned a value when loading
  from JSON.
- Added tests to verify correct handling of nullable fields in state
  persistence.
- Removed generation of legacy global install time from max in mods.
@paoloambrosio paoloambrosio marked this pull request as ready for review January 16, 2026 17:05
@paoloambrosio paoloambrosio merged commit 6fb9764 into OpenSimTools:main Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant