Big package and mod installation refactoring#148
Merged
paoloambrosio merged 6 commits intoMar 17, 2026
Conversation
- Extacted the logic for checking if a package is bootfiles into a dedicated interface `IBootfilesNameChecker` - Extracted the logic for creating mod installers into a dedicated interface `IModInstallerFactory` - Refactored `ModPackagesUpdater` to use these new interfaces, improving separation of concerns and testability
- Transformed many constants into default config - Added test for BootfilesInstaller - Minor refactor to make it more readable - Post processing event for each section only if not empty
- Execute callbacks during post-processing - Test behaviour - Refactoring of callback handling
paoloambrosio
force-pushed
the
147-config-callbacks
branch
from
5fc0284 to
9909eff
Compare
paoloambrosio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackagesUpdatertestsModPackagesUpdaterand added testsIBootfilesNameCheckerIModInstallerFactoryModInstallerand added testsPostProcessorfunctionality toBaseModInstallerBootfilesInstallerand added test