Skip to content

Implement issue #239: Inspector Graph: better component titles#254

Merged
labordep merged 2 commits intomainfrom
dev-issue239
May 1, 2026
Merged

Implement issue #239: Inspector Graph: better component titles#254
labordep merged 2 commits intomainfrom
dev-issue239

Conversation

@LabordePierre
Copy link
Copy Markdown
Member

No description provided.

@LabordePierre LabordePierre self-assigned this Apr 22, 2026
@LabordePierre LabordePierre added the enhancement New feature or request label Apr 22, 2026
Copy link
Copy Markdown
Contributor

@YannLeGoff YannLeGoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is complicated for me to understand wich label is the type, wich is the implementation and wich is the name.

What do you think of the picture ?

Image

Comment thread src/Molecule-IDE/MolComponentImpl.extension.st Outdated
@YannLeGoff
Copy link
Copy Markdown
Contributor

It is complicated for me to understand wich label is the type, wich is the implementation and wich is the name.

What do you think of the picture ?

Image

Replace Impl: with Class:

@LabordePierre
Copy link
Copy Markdown
Member Author

It is complicated for me to understand wich label is the type, wich is the implementation and wich is the name.
What do you think of the picture ?
Image

Replace Impl: with Class:

@LANDAISB any opinion? We discuss on that before the commit and I prefer not add prefix to have lighter display.

@LabordePierre
Copy link
Copy Markdown
Member Author

I prefer "Impl" instead of "Class"

@LANDAISB
Copy link
Copy Markdown
Collaborator

I prefer to add default name (ie. always display the key of component), not sure it's necessary to have a different look than a choosed name.
I think there is no need to prefix type, class, key (always same order, different looks).
Maybe just add full description (with prefix) on hover ?

@YannLeGoff
Copy link
Copy Markdown
Contributor

I added a better hover text.
image

@LabordePierre
Copy link
Copy Markdown
Member Author

I added a better hover text. image

This is fine and respond to having a "light" visual component but with more informations if needed.

@LabordePierre
Copy link
Copy Markdown
Member Author

LabordePierre commented Apr 30, 2026

I don't know why tests are not pass, but there is currently an incident:

image

Edit: ok this is nice.

@LabordePierre
Copy link
Copy Markdown
Member Author

@ELePors @LANDAISB @LouisePla, please review.

@labordep labordep merged commit f3501eb into main May 1, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants