Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Dec 28, 2025

Close #340

@augmentcode
Copy link

augmentcode bot commented Dec 28, 2025

🤖 Augment PR Summary

Summary: This PR fixes a UI snapshot mismatch caused by slight differences in color rounding between OpenSwiftUI and SwiftUI.

Changes:

  • Removes the relaxed perceptualPrecision workaround from ZStackUITests now that color output should match
  • Adds a small UITest-only initializer (C constructor + Swift entrypoint) that runs at load time
  • Enables Color.Resolved._alignWithSwiftUIImplementation for the UI test target to match SwiftUI’s rounding behavior

Technical Notes: Initialization is performed via a C attribute((constructor)) that calls a Swift function exported with @_cdecl, and only mutates the alignment flag when OPENSWIFTUI is enabled.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.25%. Comparing base (37596d3) to head (2f09c82).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (37596d3) and HEAD (2f09c82). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (37596d3) HEAD (2f09c82)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #689       +/-   ##
===========================================
- Coverage   28.73%   14.25%   -14.49%     
===========================================
  Files         588      562       -26     
  Lines       35701    33064     -2637     
===========================================
- Hits        10259     4713     -5546     
- Misses      25442    28351     +2909     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit b744311 into main Dec 28, 2025
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch December 28, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The screenshot has 1 px diff for overlay color on iOS simulator

2 participants