set/import: commit config to controller flash after writing#1
Open
lucasp0927 wants to merge 1 commit into
Open
set/import: commit config to controller flash after writing#1lucasp0927 wants to merge 1 commit into
lucasp0927 wants to merge 1 commit into
Conversation
Call the new flushConfig() after a successful writeConfig() in both the set and import paths, so V2 (Win Mini 2025 / 2f24:0137) mappings survive reboot and suspend without toggling the mode switch or re-applying on every boot. flushConfig() is a base-class no-op for V1 controllers. The flash commit replays the official app's bracket choreography and takes ~12s; print a heads-up so the pause is not mistaken for a hang. Requires the libOpenWinControls flushConfig() implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to OpenWinControls/libOpenWinControls#1, which makes
flushConfig()actually persist the config to flash on V2 controllers (fullanalysis and hardware verification over there).
This just calls it: after a successful
writeConfig()in thesetandimportpaths, so bindings survive reboot and suspend/resume without togglingthe mode switch. The flash commit takes ~12 s, so a heads-up is printed to
make clear the pause isn't a hang.
flushConfig()is a base-class no-op, soV1 controllers are unaffected.
Needs the libOpenWinControls submodule bumped once the lib PR merges.
Demo (GPD Win Mini 2025, fw 1.22, Bazzite)
Bind and flash-commit — then reboot or suspend with no switch toggle: the
binding holds.