Skip to content

docs: surface catalog capabilities, add llms.txt links, custody + changelog conventions#430

Open
bidzyyys wants to merge 4 commits into
mainfrom
docs/metadata-discovery-custody
Open

docs: surface catalog capabilities, add llms.txt links, custody + changelog conventions#430
bidzyyys wants to merge 4 commits into
mainfrom
docs/metadata-discovery-custody

Conversation

@bidzyyys

@bidzyyys bidzyyys commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Docs-only pass that improves discoverability of existing capabilities for integrators and AI agents, and codifies the conventions behind it. No code or tests touched.

Discoverability coverage

Surfaced hidden-but-public capabilities at catalog level, each backed by a real, named function in the package README:

  • fixed_point — catalog Highlights gains rounding + conversions/casts; package README adds a Rounding line (ceil/floor) and the SD29x9 abs/negate/rem helpers.
  • allowance — catalog gains on-chain queryable allowance state; package README gains an "Inspect" lifecycle step (allowance/spendable_now/expiry/contains/balance_value).
  • timelock — catalog gains dependency chaining + permissionless execution; package README Module Snapshot updated to match (predecessor gating, open-executor).
  • math/core — catalog Highlights already broadened to name decimal scaling + vector utilities.

Conventions

  • CONTRIBUTING.md — new rule: any added/changed public capability must be surfaced as a keyword in its group catalog README and be findable in the package README, kept consistent and code-backed; plus a changelog rule (record notable changes in CHANGELOG.md, grouped by package, per Keep a Changelog).
  • ARCHITECTURE.md — new "Asset custody & balances" section promoting Sui Address Balances for fungible-asset custody.
  • STYLEGUIDE.md — note that conventions are based on the Sui dev cheat sheet; add PriorityQueue to the bounded-collections list.
  • llms.txt — add README.md and STYLEGUIDE.md to the "Start here" pointers.

Summary by CodeRabbit

  • Documentation
    • Added new design guidance for fungible-asset custody, recommending Sui Address Balances.
    • Expanded contribution/PR conventions to improve discoverability and changelog recording of user-facing changes.
    • Updated contract docs: allowance now includes an Inspect lifecycle step; timelock docs cover predecessor-based chaining and optional permissionless execution.
    • Refreshed math docs for core/fixed-point functionality, including rounding and additional helpers.
    • Improved doc navigation via direct links to key repository resources, and updated contract package descriptions.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c611ac1a-3f1d-44ee-ad5b-2b93085defcc

📥 Commits

Reviewing files that changed from the base of the PR and between 7717d2a and 086b2ff.

📒 Files selected for processing (1)
  • math/fixed_point/README.md
✅ Files skipped from review due to trivial changes (1)
  • math/fixed_point/README.md

📝 Walkthrough

Walkthrough

This PR updates repository documentation only: top-level guidance files add custody, contribution, style, and discovery notes; contracts and math READMEs expand package descriptions; and allowance/timelock docs add or adjust lifecycle and capability text.

Changes

Documentation updates

Layer / File(s) Summary
Top-level guidance documents
ARCHITECTURE.md, CONTRIBUTING.md, STYLEGUIDE.md, llms.txt
Adds asset custody guidance, new contribution bullets for discoverability and changelog tracking, a style-guide attribution note plus PriorityQueue mention, and expanded start-here links.
Contracts package README updates
contracts/README.md, contracts/allowance/README.md, contracts/timelock/README.md
Revises package descriptions, inserts an Inspect lifecycle step for allowance reads, and updates timelock capability wording.
Math package README updates
math/README.md, math/fixed_point/README.md
Expands core and fixed-point package descriptions and documents additional rounding and helper operations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: 0xNeshi, ericnordelo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and captures the docs-only focus on surfacing capabilities and documenting conventions.
Description check ✅ Passed The description is well structured and covers purpose, scope, and conventions, with only minor template omissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/metadata-discovery-custody

Comment @coderabbitai help to get the list of available commands.

@bidzyyys bidzyyys requested a review from kosedogus July 2, 2026 09:50
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (bb2405c) to head (086b2ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   96.59%   96.62%   +0.02%     
==========================================
  Files          34       34              
  Lines        3405     3405              
  Branches      794      794              
==========================================
+ Hits         3289     3290       +1     
  Misses         70       70              
+ Partials       46       45       -1     
Flag Coverage Δ
contracts/access 65.46% <ø> (ø)
contracts/allowance 52.40% <ø> (ø)
contracts/finance 26.07% <ø> (ø)
contracts/timelock 54.57% <ø> (ø)
contracts/utils 44.09% <ø> (ø)
math/core 86.97% <ø> (+0.07%) ⬆️
math/fixed_point 63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/allowance/README.md`:
- Around line 50-52: Clarify the description of spendable_now<T> in the
allowance README so it is presented as an advisory ceiling rather than a
guaranteed exact amount. Update the Inspect section wording near
spendable_now<T> to explicitly note that the quoted value can still fail under
same-checkpoint contention, and make sure the phrasing is consistent with the
surrounding API names like allowance<T>, expiry<T>, contains<T>, and
balance_value<T>.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 15ce8bda-023f-425f-960c-3a7564994589

📥 Commits

Reviewing files that changed from the base of the PR and between 85448ce and 6cdc6c0.

📒 Files selected for processing (9)
  • ARCHITECTURE.md
  • CONTRIBUTING.md
  • STYLEGUIDE.md
  • contracts/README.md
  • contracts/allowance/README.md
  • contracts/timelock/README.md
  • llms.txt
  • math/README.md
  • math/fixed_point/README.md

Comment thread contracts/allowance/README.md Outdated

@ericnordelo ericnordelo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants