Skip to content

Get failed accounts and store in S3 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dilip0515 merged 106 commits into from
Jul 31, 2025
Merged

Get failed accounts and store in S3 #517

dilip0515 merged 106 commits into from
Jul 31, 2025

Conversation

@dilip0515
Copy link
Contributor

@dilip0515 dilip0515 commented Jul 15, 2025 •
edited
Loading

Proposed changes

  • Check for Accounts that are missing lp resources group in S3 and mark them as NotReady and add it to the CSV file with LP status
  • Create a script that lists aws accounts which failed to remove resource post nuke, these accounts can be pulled from Accounts table in aws account master account with the status as NotReady and out put to a file and store in a S3 in the account with notready_date file name
  • Accounts that are marked as clean but have dirty resources.-> Nuke is already marking them as dirty not required for this validation.
image image image image image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

bjfish25
bjfish25 reviewed Jul 31, 2025
View reviewed changes
cmd/lambda/list_dirty_accounts/list_dirty_accounts.go Outdated
stsSvc := sts.New(sess)

// Use OrganizationAccountAccessRole for cross-account access
roleARN := fmt.Sprintf("arn:aws:iam::%s:role/OrganizationAccountAccessRole", accountID)
Copy link
Contributor

@bjfish25 bjfish25 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to genericize this to the Admin role

Copy link
Contributor Author

@dilip0515 dilip0515 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@dilip0515 dilip0515 merged commit 8962ce9 into master Jul 31, 2025
4 checks passed
@dilip0515 dilip0515 deleted the get-failed-accounts branch July 31, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjfish25 bjfish25 bjfish25 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dilip0515 @bjfish25