Skip to content

Add warning for direct usage of six from awscli.compat #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qadeer2syed wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add warning for direct usage of six from awscli.compat #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion awscli/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from urllib.error import URLError
from urllib.request import urlopen

from botocore.compat import six, OrderedDict
from botocore.compat import OrderedDict

import sys
import zipfile
Expand Down Expand Up @@ -502,3 +502,20 @@ def _linux_distribution(
if _id:
id = _id
return distname, version, id


def __getattr__(name):
"""
Module override to raise warnings when deprecated libraries
are imported in external code.
"""
if name == "six":
warnstr = (
"The awscli.compat.six module is deprecated and will be removed "
"in a future version. Please use six as a direct dependency."
)
warnings.warn(warnstr, DeprecationWarning, stacklevel=2)
from botocore.compat import six
return six

raise AttributeError(f"Module {__name__} has no attribute {name}.")