ci: add Ruff config, pre-commit hooks, and GitHub Actions lint workflow#7
Open
korbonits wants to merge 1 commit intoOsilly:mainfrom
Open
ci: add Ruff config, pre-commit hooks, and GitHub Actions lint workflow#7korbonits wants to merge 1 commit intoOsilly:mainfrom
korbonits wants to merge 1 commit intoOsilly:mainfrom
Conversation
ruff and pre-commit were already declared as dev dependencies but never configured. This PR wires them up: - Add [tool.ruff] config to pyproject.toml (E/F/I rules, 120-char limit, per-file ignores for __init__.py) - Add .pre-commit-config.yaml with ruff lint + format hooks - Add .github/workflows/lint.yml using uv for fast installs - Auto-fix 127 violations (unsorted imports, unused imports, f-strings) - Fix duplicate save_json definition in data_utils.py (F811) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[tool.ruff]config topyproject.toml—ruffwas already indevdependencies but had no configuration.pre-commit-config.yamlwiring up Ruff lint + format hooks —pre-commitwas already indevdependencies but had no config file.github/workflows/lint.ymlusinguvfor fast installssave_jsondefinition inSFT/eval/vlm/eval/mmmu/data_utils.py(F811)Motivation
pyproject.tomlalready declared bothruffandpre-commitas dev dependencies, signaling intent to set up tooling — this PR completes that setup. No new rules were introduced beyond a standard E/F/I selection; conservative ignores (E501, E402, E722, etc.) keep the config non-intrusive.What's not included
Testing
Ran
ruff check .andruff format --check .locally — all checks pass.