Conversation
The test was misusing csv_start_row as a data row selector, but the API defines it as the file row where the header is located. Fixed by creating a CSV with preamble metadata lines so csv_start_row correctly points to the header row. Also removed unused imports and fixed spacing.
chanshing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions workflow to run the pytest test suite with coverage on every push/PR. Also includes a test fix.
Files Changed
.github/workflows/pytest.yaml(new)flake8.yamltriggers and setup conventionspip install -e .[dev]for test dependenciestests/test_utils.pytest_read_csv_with_row_limitsto match actualcsv_start_row/csv_end_rowsemantics (header row vs data offset)