chore: 删除一些无用代码#2817
Merged
Merged
Conversation
审阅者指南(在小型 PR 上折叠)审阅者指南此 PR 移除遗留/死代码并清理条件编译遗留物,同时收紧围绕导出逻辑的实际 含条件编译的 PCL 导出逻辑流程图flowchart TD
Start[StartExport_called] --> PrepPCL[Prepare_PCL_files_region]
PrepPCL --> CheckIncludePCLDev[Check_IncludePCL_in_non_RELEASE_build]
CheckIncludePCLDev -->|!RELEASE_build_and_IncludePCL_true| AddDownloadLoader[Add_LoaderTask_to_download_PCL_release_exe]
CheckIncludePCLDev -->|!RELEASE_build_and_IncludePCL_false| SkipDownloadLoader[Skip_downloading_PCL]
AddDownloadLoader --> ContinueExport[Continue_export_pipeline]
SkipDownloadLoader --> ContinueExport
ContinueExport --> CopyInstanceSettings[Copy_PCL_instance_settings]
CopyInstanceSettings --> CheckIncludePCLRelease[Check_IncludePCL_in_RELEASE_build]
CheckIncludePCLRelease -->|RELEASE_build_and_IncludePCL_true| CopyPCLExe[Copy_PCL_executable_into_exported_package]
CheckIncludePCLRelease -->|RELEASE_build_and_IncludePCL_false| SkipCopyPCLExe[Skip_copying_PCL_executable]
CopyPCLExe --> CopyCustom[Copy_PCL_customization_files_if_IncludePCLCustom]
SkipCopyPCLExe --> CopyCustom
CopyCustom --> End[Export_completed]
文件级变更
技巧与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes legacy/dead code and cleans up conditional compilation artifacts, while tightening up actual #if/#endif usage around export logic. Flow diagram for PCL export logic with conditional compilationflowchart TD
Start[StartExport_called] --> PrepPCL[Prepare_PCL_files_region]
PrepPCL --> CheckIncludePCLDev[Check_IncludePCL_in_non_RELEASE_build]
CheckIncludePCLDev -->|!RELEASE_build_and_IncludePCL_true| AddDownloadLoader[Add_LoaderTask_to_download_PCL_release_exe]
CheckIncludePCLDev -->|!RELEASE_build_and_IncludePCL_false| SkipDownloadLoader[Skip_downloading_PCL]
AddDownloadLoader --> ContinueExport[Continue_export_pipeline]
SkipDownloadLoader --> ContinueExport
ContinueExport --> CopyInstanceSettings[Copy_PCL_instance_settings]
CopyInstanceSettings --> CheckIncludePCLRelease[Check_IncludePCL_in_RELEASE_build]
CheckIncludePCLRelease -->|RELEASE_build_and_IncludePCL_true| CopyPCLExe[Copy_PCL_executable_into_exported_package]
CheckIncludePCLRelease -->|RELEASE_build_and_IncludePCL_false| SkipCopyPCLExe[Skip_copying_PCL_executable]
CopyPCLExe --> CopyCustom[Copy_PCL_customization_files_if_IncludePCLCustom]
SkipCopyPCLExe --> CopyCustom
CopyCustom --> End[Export_completed]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
MoYuan-CN
approved these changes
May 11, 2026
SALTWOOD
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
移除与 HTTP 服务器实现、仅调试用的 CLI 代码路径以及条件编译遗留相关的过时和未使用旧代码,同时清理导出和日志流程中的预处理指令。
Enhancements:
#if RELEASE/#if !RELEASE宏守卫,简化PageInstance的导出逻辑。Chores:
Original summary in English
Summary by Sourcery
Remove obsolete and unused legacy code related to HTTP server implementation, debug-only CLI paths, and conditional compilation remnants, while cleaning up preprocessor directives in export and logging flows.
Enhancements:
Chores: