Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the math expression parser and visitor framework to support Greek letter tokens and infinity, as well as unary plus and minus operators. It also standardizes import paths for ANTLR-generated classes. These changes improve the parser's ability to handle mathematical notation more naturally and in a way that's closer to LaTeX.
Parser and Grammar Enhancements:
GREEKandINFINITYtokens toMathLexer.g4, enabling recognition of Greek letter names (both lowercase and uppercase) and various representations of infinity.MathParser.g4to support unary plus/minus operators, Greek letter tokens, and infinity as valid expressions.Visitor and Output Handling:
visitUnarySigninAlgebraVisitorto handle unary plus and minus expressions.visitInfinityinBasicVisitorto output\inftyfor infinity tokens.GreekVisitorinMainVisitorand routed Greek and infinity expressions to the appropriate visitors.