-
-
Notifications
You must be signed in to change notification settings - Fork 21
Don't emit warnings for circular values #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinstuecklschwaiger
wants to merge
3
commits into
PHP-DI:master
Choose a base branch
from
martinstuecklschwaiger:circular-references
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Invoker\Test\Exception; | ||
|
|
||
| use Invoker\Exception\NotCallableException; | ||
| use PHPUnit\Framework\TestCase; | ||
| use stdClass; | ||
|
|
||
| class NotCallableExceptionTest extends TestCase | ||
| { | ||
| /** | ||
| * @test | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\Test] | ||
| public function handles_object_with_circular_reference() | ||
| { | ||
| $obj = new stdClass(); | ||
| $obj->self = $obj; | ||
|
|
||
| $exception = NotCallableException::fromInvalidCallable($obj); | ||
|
|
||
| $this->assertSame('Instance of stdClass is not a callable', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\Test] | ||
| public function handles_array_with_object_and_null_method() | ||
| { | ||
| $obj = new stdClass(); | ||
|
|
||
| $exception = NotCallableException::fromInvalidCallable([$obj, null]); | ||
|
|
||
| $this->assertSame('stdClass::() is not a callable.', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\Test] | ||
| public function handles_circular_array_reference() | ||
| { | ||
| $a = []; | ||
| $a[] = &$a; | ||
|
|
||
| $exception = NotCallableException::fromInvalidCallable($a); | ||
|
|
||
| $this->assertStringContainsString('is not a callable', $exception->getMessage()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\Test] | ||
| public function handles_circular_array_reference_as_container_entry() | ||
| { | ||
| $a = []; | ||
| $a[] = &$a; | ||
|
|
||
| $exception = NotCallableException::fromInvalidCallable($a, true); | ||
|
|
||
| $this->assertStringContainsString('is neither a callable nor a valid container entry', $exception->getMessage()); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same thing here |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not assert on the entire message? (that we we know what the exception message will be, here I'm not sure what it will be)