Skip to content

🎉 (sample/features) add_field: check field size consistency with geometrical support#361

Merged
casenave merged 9 commits intomainfrom
issue357
Apr 2, 2026
Merged

🎉 (sample/features) add_field: check field size consistency with geometrical support#361
casenave merged 9 commits intomainfrom
issue357

Conversation

@tdaniel06
Copy link
Copy Markdown
Contributor

📋 Description (optional)

PR related to Issue 357: check consistency of field shape with number of nodes/cells of its support.

To be discussed: cases where location not in ["Vertex", "CellCenter"].


🔗 Related issues (optional)

Closes #357

@tdaniel06 tdaniel06 requested a review from casenave April 1, 2026 14:38
@casenave casenave changed the title 🐛 Check field size consistency with geometrical support 🎉 Check field size consistency with geometrical support Apr 1, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 1, 2026

CLA assistant check
All committers have signed the CLA.

@casenave casenave changed the title 🎉 Check field size consistency with geometrical support 🎉 (sample/features) add_fieldd: check field size consistency with geometrical support Apr 1, 2026
@casenave
Copy link
Copy Markdown
Member

casenave commented Apr 1, 2026

@tdaniel06 can you please sign the CLI ?

@casenave casenave marked this pull request as ready for review April 1, 2026 18:14
@casenave casenave requested a review from a team as a code owner April 1, 2026 18:14
@casenave casenave marked this pull request as draft April 1, 2026 18:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave casenave marked this pull request as ready for review April 1, 2026 18:58
@casenave casenave changed the title 🎉 (sample/features) add_fieldd: check field size consistency with geometrical support 🎉 (sample/features) add_field: check field size consistency with geometrical support Apr 2, 2026
@casenave casenave merged commit 248c5f7 into main Apr 2, 2026
23 checks passed
@casenave casenave deleted the issue357 branch April 2, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add size check when adding a field

4 participants