Open
Conversation
…ounders_concurrent call in this test. Additionally making a name==main in the test so I could run it locally without worrying about tox. This should be undone almost immediately, but I wanted to demonstrate to myself that the use of the logger is correct
Since that repo is a modern version, it has a slightly different interface including new class names. Had to tweak pounders.py to get it using the logging facilities. Note that POUNDers unittests are presently failing due to the need to update concurrent POUNDers in accord with other changes made on this branch. tox tasks were passing locally aside from the above.
Collaborator
|
I have updated the package so that The actions now seem to be using the logger well. However, there are unrelated failures related to concurrent pounders that cause actions to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are certainly going to fail because of the use of logger. But, locally, this use of logger works. This PR is a jumping off point for better discussions about how to properly use POptUS logging tools instead of just printing to terminal. While this PR was always something we intended to do in (minimally) pounders and manifold sampling, it was bumped up in priority because this is a first step in closing the gradient_pounders branch.