Matlab R2024b some "Analyze Code" fixes#53
Open
thomas-nilsson-irfu wants to merge 1 commit intoPRBEM:mainfrom
Open
Matlab R2024b some "Analyze Code" fixes#53thomas-nilsson-irfu wants to merge 1 commit intoPRBEM:mainfrom
thomas-nilsson-irfu wants to merge 1 commit intoPRBEM:mainfrom
Conversation
- "length(X)==1" and "numel(X)==1" changed to "isscalar(X)".
- Assigned but unused parameters replaced by "~".
- Silence a warning about unreachable test code (if true, X, else, Y; end).
- Remove output argument for function which never set this argument
('info' in onera_desp_lib_load.m).
thomas-nilsson-irfu
had a problem deploying
to
github-pages
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included are the following:
The Matlab's
now- is currently being discouraged, as per https://se.mathworks.com/help/matlab/ref/now.html, in favour of Matlab'sdatetime. This pull request does not apply any such changes as that could break backwards compatibility with older Matlab versions (before R2014b whendatetimewas introduced).Feel free to edit this pull request directly, or comment with any potential improvements.