Renamed bmin to bmirr in find_mirror_point#55
Closed
mshumko wants to merge 7 commits intoPRBEM:mainfrom
Closed
Conversation
which ignores anything other than libirbem.dll or libirbem.so.
mshumko
had a problem deploying
to
github-pages
GitHub Actions
Failure
Contributor
|
I'm closing this PR as I can't seem to resolve the conflicts in a clean way. I've opened PR #64 to the same effects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This straight-forward PR contains the variable name change in the python wrapper's
MagFields.find_miror_point()method. The name change is also updated in the test suite. This PR closes #54.P.S. the OSX test fails because the OSX GitHub Action does not have a gfortran compiler anymore:
Unless a simple fix is identified during the review, I'll save updating GitHub Actions to a future PR.