Update IntervalArithmetic and ForwardDiff dependencies#73
Merged
DimitriAlston merged 6 commits intoPSORLab:masterfrom Feb 16, 2026
Merged
Update IntervalArithmetic and ForwardDiff dependencies#73DimitriAlston merged 6 commits intoPSORLab:masterfrom
IntervalArithmetic and ForwardDiff dependencies#73DimitriAlston merged 6 commits intoPSORLab:masterfrom
Conversation
RXGottlieb
reviewed
Feb 16, 2026
Comment on lines
36
to
44
| function erf(a::Interval{T}) where T | ||
| isempty(a) && return a | ||
| @round( erf(a.lo), erf(a.hi) ) | ||
| isempty_interval(a) && return a | ||
| convert(Interval{Float64}, interval(erf(a.bareinterval.lo), erf(a.bareinterval.hi))) | ||
| end | ||
|
|
||
| function erfc(a::Interval{T}) where T | ||
| isempty(a) && return a | ||
| @round( erfc(a.hi), erfc(a.lo) ) | ||
| isempty_interval(a) && return a | ||
| convert(Interval{Float64}, interval(erfc(a.bareinterval.hi), erfc(a.bareinterval.lo))) | ||
| end |
Member
There was a problem hiding this comment.
Are these are rounding correctly?
Member
Author
There was a problem hiding this comment.
The intervals are created as Interval{BigFloat} from the error functions and then converted to Interval{Float64}, so that should preserve the original rounding.
| isempty(a) && return a | ||
| @round(erfinv(a.lo), erfinv(a.hi)) | ||
| isempty_interval(a) && return a | ||
| convert(Interval{Float64}, interval(erfinv(a.bareinterval.lo), erfinv(a.bareinterval.hi))) |
Member
There was a problem hiding this comment.
Same rounding comment as above
| @test isapprox(y12.cc, 0.534168383326423, atol=1E-8) | ||
| end | ||
|
|
||
| @testset "Test Error Functions" begin |
Member
There was a problem hiding this comment.
Why were some of these test lines removed?
Member
Author
There was a problem hiding this comment.
They were just the same tests repeated multiple times. The remaining tests still test each of the error functions.
RXGottlieb
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.