Skip to content

Conversation

@Pablo1990
Copy link
Owner

@Pablo1990 Pablo1990 commented Dec 16, 2024

First commits by Megha.

@Pablo1990 Pablo1990 marked this pull request as ready for review December 16, 2024 10:25
@codecov
Copy link

codecov bot commented Dec 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

self.debris_contribution = np.finfo(float).eps
# =========================== Contractility ==========================
self.Contractility = True
self.TypeOfPurseString = 0
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted

Comment on lines +80 to +93

def test_compute_cell_area_edge_cases(self):
geo_test, _, _ = load_data('Geo_var_3x3_stretch.mat')

# Test with zero-area cells
geo_test.Cells[0].X = np.array([[0, 0], [0, 0], [0, 0]]) # Degenerate cell
geo_test.Cells[0].compute_area()
self.assertEqual(geo_test.Cells[0].Area, 0)

# Test with very large area
geo_test.Cells[1].X = np.array([[1e6, 1e6], [1e7, 1e7], [1e8, 1e8]]) # Extreme values
geo_test.Cells[1].compute_area()
self.assertTrue(geo_test.Cells[1].Area > 0) # a non-zero area

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need further explanation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the name
Y instead of X for calc areas coz Y - vertices

@Pablo1990 Pablo1990 merged commit 010cef2 into main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants