Skip to content

fix: Instantiate null logger once #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgrayston-paddle merged 1 commit into from
Apr 21, 2026
Merged

fix: Instantiate null logger once #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

Check our main [developer changelog](https://developer.paddle.com/?utm_source=dx&utm_medium=paddle-python-sdk) for information about changes to the Paddle Billing platform, the Paddle API, and other developer tools.

## 1.14.1 - 2026-04-21

### Fixed

- Fixed a handler leak in `Client.null_logger()` where a new `NullHandler` was attached to the shared `"null_logger"` logger on every `Client` instantiation. The `NullHandler` is now only attached when the logger has no handlers configured.

## 1.14.0 - 2026-03-30

### Added
Expand Down
5 changes: 3 additions & 2 deletions paddle_billing/Client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def null_logger() -> Logger:
"""

null_logger = getLogger("null_logger")
null_logger.addHandler(NullHandler())
if not null_logger.handlers:
null_logger.addHandler(NullHandler())

return null_logger

Expand Down Expand Up @@ -202,7 +203,7 @@ def build_request_session(self) -> Session:
"Authorization": f"Bearer {self.__api_key}",
"Content-Type": "application/json",
"Paddle-Version": str(self.use_api_version),
"User-Agent": "PaddleSDK/python 1.14.0",
"User-Agent": "PaddleSDK/python 1.14.1",
}
)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from setuptools import setup, find_packages

setup(
version="1.14.0",
version="1.14.1",
author="Paddle and contributors",
author_email="team-dx@paddle.com",
description="Paddle's Python SDK for Paddle Billing",
Expand Down
Loading