Skip to content

Port bin to argh so we get help text #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pajn merged 3 commits into from
Mar 21, 2026
Merged

Port bin to argh so we get help text #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a91e8dd
Port bin to argh so we get help text
Pajn Mar 18, 2026
8b3a181
Set MSRV to one that actually work
Pajn Mar 19, 2026
a8fd8d8
Install tmux in CI
Pajn Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,16 @@ jobs:
uses: actions/checkout@v4

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@master
uses: dtolnay/rust-toolchain@stable

@coderabbitai coderabbitai Bot Mar 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify all GitHub actions are pinned (no moving refs like `@main/`@master/@stable)
rg -n '^\s*uses:\s*[^@]+@(main|master|stable|v[0-9]+)$' .github/workflows

Repository: Pajn/wisp

Length of output: 251

Pin GitHub Action to a commit SHA instead of using @stable.

Line 25 uses dtolnay/rust-toolchain@stable, a moving reference that can change between runs and weakens CI reproducibility and supply-chain integrity. Pin to a specific commit SHA instead.

Suggested change 
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@<commit-sha>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml at line 25, Replace the moving reference "uses:
dtolnay/rust-toolchain@stable" with a pinned commit SHA to ensure reproducible
CI; update the workflow to "uses: dtolnay/rust-toolchain@<commit-sha>" by
finding the desired commit SHA in the dtolnay/rust-toolchain repository and
substituting it in place of "@stable" (ensure you pick a specific commit SHA and
not a tag or branch).

with:
toolchain: 1.85.0
toolchain: 1.90
components: clippy, rustfmt

- name: Install tmux
run: |
sudo apt-get update && sudo apt-get install -y tmux
tmux new-session -d

- name: Cache cargo artifacts
uses: swatinem/rust-cache@v2

Expand Down
32 changes: 32 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ resolver = "3"
[workspace.package]
version = "0.1.0"
edition = "2024"
rust-version = "1.85"
rust-version = "1.90"
license = "MIT"
publish = false

Expand Down
1 change: 1 addition & 0 deletions crates/wisp-bin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ name = "wisp"
path = "src/main.rs"

[dependencies]
argh = "0.1"
crossterm.workspace = true
ratatui.workspace = true
wisp-app = { path = "../wisp-app" }
Expand Down
Loading
Loading