Fix EntityTargetLivingEntityEvent spam in TemptGoal #13405
+23
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, TemptGoal#canUse fires EntityTargetLivingEntityEvent unconditionally every time a valid target is found. Since canContinueToUse delegates to canUse to verify if the player is still valid/holding the item, this results in the event being fired every single tick for every mob being tempted. This creates significant unnecessary overhead and spams plugins that listen to target changes.
This patch adds a check to ensure EntityTargetLivingEntityEvent is only fired when the target actually changes (or is initially found), rather than on every tick of the goal execution.