Add an option to WorldCreator to avoid spawn location computation on world creation #13407
Conversation
…world creation This reduces world creation for vanilla worlds from ~1 second to 20ms.
Owen1212055
changed the title
Malfrador
left a comment
Malfrador
left a comment
There was a problem hiding this comment.
Very happy this finally gets added to WorldCreator itself. LGTM, I only have a minor Javadocs suggestion.
| try { | ||
| - setInitialSpawn(serverLevel, serverLevelData, worldOptions.generateBonusChest(), isDebugWorld, this.levelLoadListener); | ||
| + setInitialSpawn(serverLevel, serverLevelData, worldOptions.generateBonusChest(), isDebugWorld, serverLevel.levelLoadListener); // Paper - per world level load listener | ||
| + if (computeSpawnLocation) setInitialSpawn(serverLevel, serverLevelData, worldOptions.generateBonusChest(), isDebugWorld, serverLevel.levelLoadListener); // Paper - per world level load listener & rework world loading process |
There was a problem hiding this comment.
I think we are gonna run into issues just completely skipping this call to setInitialSpawn. There's a bunch of other stuff in there which still needs to happen.
There was a problem hiding this comment.
For example, it skips calling setSpawn on the level data leading it to all worlds having the default which includes a GlobalPos to 0, 0, 0 in the overworld, not their specific world.
Also, it skips calling getFixedSpawnLocation on custom chunk generators.
And it skips placing the bonus chest.
And idk if this affects anything, but it skips running the LevelLoadListener.
github-project-automation
bot
moved this from PR Party candidate
to Changes required
in Paper PR Queue
This reduces world creation for vanilla worlds from ~1 second to 20ms.