-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Make arrow despawn rate override configurable #13409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change PaperMC#3859 forces all arrows to despawn after 10 seconds to fix MC-125757, but this was marks as works-as-intended. This change allows admins to configure this value (or disable with -1) while keeping the existing behaviour
|
maybe this could use |
|
Any chance I could get a quick review on this? Doesn't need to be merged urgently, but I would like to know if there's more you need for me to do before it's acceptable |
paper-server/src/main/java/io/papermc/paper/configuration/WorldConfiguration.java
Outdated
Show resolved
Hide resolved
...-server/patches/sources/net/minecraft/world/entity/projectile/arrow/AbstractArrow.java.patch
Outdated
Show resolved
Hide resolved
|
Logic looks all correct to me, now to the most annoying part about this config option and the reason I hoped we could avoid this. The name 😓 This isn't an override on the despawn rate, what it does is it removes the immunity of arrows that have not landed in ground yet from despawning after 200 ticks. But after that is gone, the ticking starts. I shall throw this at paper-contrib and get some opinions. |
|
It'll get merged when it gets merged :) I'm just trying to signal that I'm active and happy to implement any feedback and do any other testing that's required. |
Docs for PaperMC/Paper#13409 . Name still TBC
|
Doc PR ready, waiting on final name for config item PaperMC/docs#701 |
Change #3859 forces all arrows to despawn after 10 seconds to fix MC-125757, but this was marks as works-as-intended. This change allows admins to configure this value (or disable with -1) while keeping the existing behaviour