Skip to content

Conversation

@samrussell
Copy link

Change #3859 forces all arrows to despawn after 10 seconds to fix MC-125757, but this was marks as works-as-intended. This change allows admins to configure this value (or disable with -1) while keeping the existing behaviour

Change PaperMC#3859 forces all arrows to despawn after 10 seconds to fix
MC-125757, but this was marks as works-as-intended. This change
allows admins to configure this value (or disable with -1) while
keeping the existing behaviour
@Toffikk
Copy link

Toffikk commented Dec 20, 2025

maybe this could use IntOr.Disabled so the config set to disabled (by default) would mean the arrows follow vanilla’s way of despawning and if someone specifies an int, then it follows that. I don’t see why we would keep the 10 seconds by default given it changes vanilla behaviour.

@samrussell
Copy link
Author

Any chance I could get a quick review on this? Doesn't need to be merged urgently, but I would like to know if there's more you need for me to do before it's acceptable

@lynxplay
Copy link
Contributor

lynxplay commented Dec 23, 2025

Logic looks all correct to me, now to the most annoying part about this config option and the reason I hoped we could avoid this.

The name 😓 This isn't an override on the despawn rate, what it does is it removes the immunity of arrows that have not landed in ground yet from despawning after 200 ticks. But after that is gone, the ticking starts.
Conveying that in a single config name is going to be terribly annoying.
Obviously you want this merged fast and I dont want this config option to be around for too long before I get to replace it with the tag support in time-to-live, so I think neither of us really cares too much about the perfect name, sadly I don't really have much of an idea.

I shall throw this at paper-contrib and get some opinions.

@samrussell
Copy link
Author

It'll get merged when it gets merged :) I'm just trying to signal that I'm active and happy to implement any feedback and do any other testing that's required.

@samrussell
Copy link
Author

Doc PR ready, waiting on final name for config item PaperMC/docs#701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

3 participants