Add PlayerTransientModifierUpdateEvent #13430
Draft
+102
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use for this event is cancelling the effect that crouching has on the waypoint transmit range attribute. I gave it a rather generic name because I meant to add calls for the other attributes there however it just felt like a bunch of useless diff, so I reserved it only for the waypoint transmit range attribute. With that being the case, I can change the name into something more specific (any suggestions?), I kept it that way in case more attributes end up being changed in the future the same way (though I doubt that'll be the case).
I have not tested it yet, so I'll leave it as a draft for now. Published it mostly to get suggestions on the name.
Note: just in case it gets asked later, you cannot use the PlayerToggleSneakEvent as it gets fired way too early for this