fix: address simple PRT3 review follow-ups#599
Open
yozik04 wants to merge 1 commit into
Open
Conversation
Bundle of low-risk PRT3 follow-ups from the PR #596 review: - M1 silent drop of unmapped element events: drop manual existence guard in _apply_prt3_event_change so fire-alarm/zone events for unlabeled zones beyond PRT3_MAX_ZONES are still applied (MemoryStorage already auto-creates). - M2 retried panic/arm can double-fire: set retries=1 on send_panic and control_partitions; these commands are not idempotent and a retry after a lost echo can re-trigger panic or move arm state twice. - M4 startup label-load worst case: extend startup warning to cover PRT3_MAX_USERS + PRT3_MAX_AREAS as well as zones. - M5 user code in packet dumps: redact AA/AD payloads at the protocol layer when LOGGING_DUMP_PACKETS is enabled; previously only the panel-layer logs were redacted. - Minor: accept &fail case-insensitively for symmetry with &OK/&ok. - Minor: remove dead EVENT_MAP/PRT3Event imports from prt3/panel.py. - Minor: fix pre-existing "definitons_loaded" subscriber typo (publisher sends "definitions_loaded"). - Also: convert two pre-existing lambdas to defs and remove two unused imports to clear flake8 in touched files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle of low-risk PRT3 follow-ups from the PR #596 review:
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com