Open
Conversation
-. 계좌 상태가 ACTIVE가 아니면 입금불가 구현 -. 최대 입금한도 100만원을 초과할경우 입근 불가 -.계좌 해지 시 잔액이 존재하면 사용자가 지정한 출금 계좌로 자동 이체 refactor: -. AccountManagementService 생성 및 계좌 해지, 복구, 만료 삭제 책임 분리 - 트랜잭션 응답 Record 객체 일관화 (TransferResponseRecord, DepositRecord 등) - 거래 내역 기간/정렬 조회 기능 refactoring
Open
Paransaik
reviewed
May 30, 2025
Paransaik
reviewed
May 30, 2025
-. 필터검색을 dto로 만들어서 관리하도록 변경 -.validatePendingLoanOrAutoTransfer 메서드 분리하여 단일책임 원칙 적용
-. 필터검색을 dto로 만들어서 관리하도록 변경 -.validatePendingLoanOrAutoTransfer 메서드 분리하여 단일책임 원칙 적용
…LoanOrAutoTransfer 메서드 분리하여 단일책임 원칙 적용
Paransaik
reviewed
Jun 10, 2025
| @RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME) LocalDateTime startDate, | ||
| @RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME) LocalDateTime endDate, | ||
| @RequestParam(defaultValue = "true") boolean sortDesc, | ||
| @ModelAttribute TransferSearchRequestRecord searchRequest, |
Member
There was a problem hiding this comment.
-
ModelAttribute로 TransferSearchRequestRecord를 받으셨는데, 사용은 안하시네요? 필터 비지니스 로직이 들어가야하지 않나요?
-
DTO를 2개 못 받으셔서 ModelAttribute로 받으신 거 같은데, TransferRequestRecord 하나의 DTO에 filter 조건도 한번에 받으시면 안되시는 건가요?
Paransaik
reviewed
Jun 10, 2025
| this.account = account; | ||
| this.balance = dto.balance(); | ||
| // this.loanDate = LocalDateTime.now(); | ||
| this.loanDate = LocalDateTime.now(); |
| Boolean sortDesc, | ||
|
|
||
| String transactionType | ||
| ) {} |
| private final UserRepository userRepository; | ||
|
|
||
| public Account createAccount(Account account) { | ||
| return accountRepository.save(account); |
Member
There was a problem hiding this comment.
account 만드실 때 user 넣어주셔야 하는데, 아래 메소드 사용하시는게 맞지 않을까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
개발 상세 내역
✅ 1. 계좌 관련 기능 개선
✅ 2. 구조 개선 및 리팩토링
✅ 3. ENUM ERRORCODE추가